Feature/2535 split file #741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into split-file_attributedef.class.inc.php
….php' into split-file_attributedef.class.inc.php
…ge.php' into split-file_attributedef.class.inc.php
…ber.php' into split-file_attributedef.class.inc.php
…Set.php' into split-file_attributedef.class.inc.php
…CodeSet.php' into split-file_attributedef.class.inc.php
…cySettings.php' into split-file_attributedef.class.inc.php
… into split-file_attributedef.class.inc.php
…h.php' into split-file_attributedef.class.inc.php
…hp' into split-file_attributedef.class.inc.php
…php' into split-file_attributedef.class.inc.php
…p' into split-file_attributedef.class.inc.php
…hp' into split-file_attributedef.class.inc.php
…HTML.php' into split-file_attributedef.class.inc.php
…String.php' into split-file_attributedef.class.inc.php
…Text.php' into split-file_attributedef.class.inc.php
…' into split-file_attributedef.class.inc.php
… into split-file_attributedef.class.inc.php
…By.php' into split-file_attributedef.class.inc.php
…ption.php' into split-file_attributedef.class.inc.php
Hipska
suggested changes
Aug 28, 2025
Hipska
reviewed
Aug 28, 2025
lib/autoload.php
Outdated
Comment on lines
17
to
20
| throw new RuntimeException($err); | ||
| trigger_error( | ||
| $err, | ||
| E_USER_ERROR | ||
| ); |
There was a problem hiding this comment.
This seems like a backward change..
There was a problem hiding this comment.
Good point, this change was made automatically by the composer
|
Is there a particular reason why you don't move these files in the |
|
I've done the first step of splitting the files. Next week, we'll discuss their final placement. |
…split-file_counter.class.inc.php
…o split-file_counter.class.inc.php
4 tasks
|
Too many commits on this PR, and it's impossible to squash it without losing the Git history. Keep it for split files. |
|
Yeah, I also prefer not to use squash just for that reason; loosing history 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many commits on this PR, and it's impossible to squash it without losing the Git history. Keep it for split files.
Split files :
core/action.class.inc.php
core/asynctask.class.inc.php
core/attributedef.class.inc.php
core/event.class.inc.php
core/valuesetdef.class.inc.php
core/event.class.inc.php