Skip to content

Conversation

@sslichnyi
Copy link

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket?
Type of change? Bug fix / Enhancement / Translations

Symptom (bug) / Objective (enhancement)

Reproduction procedure (bug)

  1. On iTop x.y.z
  2. With PHP x.y.z
  3. First go there
  4. Then do that
  5. ...
  6. Finally, see that...

Cause (bug)

Proposed solution (bug and enhancement)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Checklist of things to do before PR is ready to merge

  • ...
  • ...
  • ...

));


Dict::Add('RU RU', 'Russian', 'Русский', array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.
Thank you!

@jf-cbd
Copy link
Member

jf-cbd commented Sep 25, 2025

Hello @sslichnyi, thanks for your PR :D I see that its state is "Draft", do you plan to make some editions on it ?

@sslichnyi
Copy link
Author

@jf-cbd Sorry for responding late.
I need to finish it first. It is not done yet

@jf-cbd
Copy link
Member

jf-cbd commented Oct 10, 2025

Sure, no problem @sslichnyi 😊 I was just asking to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: First review needed

Development

Successfully merging this pull request may close these issues.

3 participants