Skip to content

N°8123 - Improve on mention data parsing #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

N°8123 - Improve on mention data parsing #749

wants to merge 2 commits into from

Conversation

@jf-cbd
Copy link
Member

@jf-cbd jf-cbd commented Sep 15, 2025 •
edited
Loading

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? N°8123
Type of change? Enhancement

Objective (enhancement)

Avoid using regex (or at least improve the current one) to detect pattern in HTML

Proposed solution (bug and enhancement)

Use XPath, which is more appropriate and safer than regex

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Checklist of things to do before PR is ready to merge

  • Existing unit tests are not breaking

@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Sep 15, 2025
@jf-cbd jf-cbd closed this Sep 15, 2025
@jf-cbd jf-cbd reopened this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Molkobain Molkobain Molkobain approved these changes

Assignees

No one assigned

Labels

internal Work made by Combodo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jf-cbd @Molkobain @CombodoApplicationsAccount