Skip to content

Conversation

@Hipska
Copy link
Contributor

@Hipska Hipska commented Oct 2, 2025

Base information

Question Answer
Related to a SourceForge thead / Another PR / Combodo ticket? N/A
Type of change? Enhancement

Objective

When clicking on a Typology item from a linked object, it is sometimes handy to see which other objects are also linking to the same Typology object.

Proposed solution

Add tabs to the Typology objects to see which other objects are using this Typology.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Checklist of things to do before PR is ready to merge

  • Add dictionary items when the additional fields are accepted

@github-project-automation github-project-automation bot moved this to First review needed in Combodo PRs dashboard Oct 2, 2025
@jf-cbd jf-cbd moved this from First review needed to Hacktoberfest in Combodo PRs dashboard Oct 7, 2025
@jf-cbd jf-cbd changed the title feat(Typology): Add useful tabs to certain typology classes N°7570 - feat(Typology): Add useful tabs to certain typology classes Oct 16, 2025
Copy link
Member

@jf-cbd jf-cbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, here are a few notices :)

<field id="ospatches_list" xsi:type="AttributeLinkedSet">
<linked_class>OSPatch</linked_class>
<ext_key_to_me>osversion_id</ext_key_to_me>
<edit_mode>add_remove</edit_mode>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "add_remove" and not "none" ? (same question for all the added fields)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to add or remove some of them?

@jf-cbd jf-cbd moved this from Hacktoberfest to Pending functional review in Combodo PRs dashboard Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Pending functional review

Development

Successfully merging this pull request may close these issues.

2 participants