Skip to content

Conversation

@ozan-cristan
Copy link

@ozan-cristan ozan-cristan commented Oct 28, 2025

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N/A
Type of change? Translations

Objective (enhancement)

Add and complete the Spanish (es_CR) translation file for iTop modules.

Details

  • Added missing translation entries for LogicalVolume attributes:
    • org_id, location_id, and location_name.
  • Ensured consistency with existing Spanish dictionaries.
  • File encoding: UTF-8 (no BOM).

Motivation

Improves user experience for Spanish-speaking iTop users and ensures consistent localization across CMDB classes.

Proposed solution

Added new entries in the Spanish dictionary:

'Class:LogicalVolume/Attribute:org_id' => 'Organización',
'Class:LogicalVolume/Attribute:org_id+' => 'Organización',
'Class:LogicalVolume/Attribute:location_id' => 'Ubicación',
'Class:LogicalVolume/Attribute:location_id+' => 'Ubicación',
'Class:LogicalVolume/Attribute:location_name' => 'Nombre de la ubicación',
'Class:LogicalVolume/Attribute:location_name+' => 'Nombre de la ubicación',

Reproduction procedure (bug)

  1. On iTop x.y.z
  2. With PHP x.y.z
  3. First go there
  4. Then do that
  5. ...
  6. Finally, see that...

Cause (bug)

Proposed solution (bug and enhancement)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • Is the PR clear and detailed enough so anyone can understand digging in the code?

Checklist of things to do before PR is ready to merge

  • ...
  • ...
  • ...

@jf-cbd
Copy link
Member

jf-cbd commented Oct 30, 2025

Hello, thank you for this PR.
Could you please indicate me where these strings are used ?

@jf-cbd jf-cbd moved this from Hacktoberfest to Pending technical review in Combodo PRs dashboard Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Pending technical review

Development

Successfully merging this pull request may close these issues.

3 participants