N°8162 - Issue when synchronizing datasource with read-only notify_contact_id_archive_flag #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipska
approved these changes
Feb 6, 2025
Co-authored-by: Thomas Casteleyn <[email protected]>
rquetiez
requested changes
Jul 10, 2025
| * @var string TABLENAME_PATTERN used to validate data synchro table name | ||
| */ | ||
| const TABLENAME_PATTERN = '/^[A-Za-z0-9_]*$/'; | ||
| const READONLY_FIELDS = [ |
There was a problem hiding this comment.
- Such a list depends on the datamodel: depending on class properties, the list of magical fields (related to obsolescence or archive) may vary.
The class "User" is not often subject to change, but The class "Contact" can be customized easily. - It is weird that you did not encounter the case with obsolescence_date and archive_date.
There was a problem hiding this comment.
readonly fields here are related to DataSynchro objects. not Contact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Current PR aims at gathering all special attributes at the same place. These attributes should not be taken into account to deal with datasource computation/synchronization.
Symptom
Datasource synchronization may fail with below error due to a regression (PR 32/ N°6115):
[Error] Failed to update the SynchroDataSource 'XXX' (2). Reason: Error: notify_contact_id_archive_flag: Attempting to set the value on the read-only attribute SynchroDataSource::notify_contact_id_archive_flag (100)Corollary
Datasource computation has been enhanced and related test coverage completed...