Add detection of iTop API versions 1.3 and 1.4. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to First review needed
in Combodo PRs dashboard
Hipska
suggested changes
Sep 10, 2025
| /** | ||
| * Gets the iTop API version in use. It tries all the known versions, starting from the newest one. | ||
| * | ||
| * @return void |
There was a problem hiding this comment.
This method is not returning a void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Symptom (bug) / Objective (enhancement)
Enhancement: Ability to detect iTop API versions 1.3 and 1.4 ( https://www.itophub.io/wiki/page?id=latest:advancedtopics:rest_json#changes_history )
It also changes the logic to try most recent versions of the API first.
Proposed solution (bug and enhancement)
Just add the missing values.
Checklist before requesting a review
Checklist of things to do before PR is ready to merge