Added options for enableVirtualization #3874
Open
+188
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtualization options
Fix for enabledVirtualisation.columns == undefined defaulting to fals…
|
|
| */ | ||
| /** @default true */ | ||
| enableVirtualization?: Maybe<boolean>; | ||
| enableVirtualization?: Maybe<boolean | VirtualizationOptions>; |
There was a problem hiding this comment.
Suggested change
| enableVirtualization?: Maybe<boolean | VirtualizationOptions>; | |
| enableVirtualization?: Maybe<'row' | 'column' | boolean>; |
I think we can keep it simple for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed type of enableVirtualization property on DataGrid to accept either a boolean, undefiend or a VirtualizationOptions object
which allows the user to enable or disable virtualization for rows and or columns and also specify the overscan threshold for rows (default 4).
Change maintains compatibility with existing boolean type and defaults.
Fixes #3619