Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate drag preview for node library nodes #2387

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Generate drag preview for node library nodes #2387

merged 3 commits into from
Jan 30, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 30, 2025

Screen.Recording.2025-01-30.at.10.54.11.AM.mov

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner January 30, 2025 18:54
@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Jan 30, 2025
loc.clientX - 20,
loc.clientY
loc.clientX,
loc.clientY + LiteGraph.NODE_TITLE_HEIGHT
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the offset to minimize layout shift.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2025-01-30.at.11.04.07.AM.mov

@huchenlei huchenlei removed the New Browser Test Expectations New browser test screenshot should be set by github action label Jan 30, 2025
@huchenlei huchenlei merged commit 8ef3b87 into main Jan 30, 2025
10 of 11 checks passed
@huchenlei huchenlei deleted the drag_preview branch January 30, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant