Handle timeout issue for node-pack-extract

node-pack-extract/cloudbuild.yaml

@@ -13,6 +13,8 @@ steps:
       - "--env"
       - "AUTO_UPDATE=true"
       - "--env"
+      - "TIMEOUT=3600"
+      - "--env"
       - "CUSTOM_NODE_URL=$_CUSTOM_NODE_URL"
       - "--env"
       - "CUSTOM_NODE_NAME=$_CUSTOM_NODE_NAME"
@@ -22,6 +24,8 @@ steps:
       - "/workspace"
       - "gcr.io/$PROJECT_ID/comfyui-nodepack"
       - "$_CUSTOM_NODE_NAME.json"
+    timeout: 5400s # 90 minutes
+    allowFailure: true
 
   - name: "gcr.io/google.com/cloudsdktool/cloud-sdk:slim"
     entrypoint: "bash"
@@ -57,3 +61,4 @@ substitutions:
 
 options:
   logging: CLOUD_LOGGING_ONLY
+timeout: 5400s # 90 minutes

node-pack-extract/entrypoint.sh

@@ -1,14 +1,23 @@
-#!/bin/sh
+#!/bin/bash
 set -e
 
-# run the original endpoint 
+# run the original endpoint
 init.sh &
 
 # loop until we can extract the node information
+TIMEOUT=${TIMEOUT:-3600}
 OUTPUTFILE=${1:-"/tmp/output.json"}
-echo -n > "$OUTPUTFILE"
+echo -n >"$OUTPUTFILE"
 until cat "$OUTPUTFILE" | grep ''; do
     sleep 1
+
+    echo "$SECONDS $TIMEOUT"
+    if ((SECONDS >= TIMEOUT)); then
+        jq -n '{success: false, reason: "timeout"}' | tee "$OUTPUTFILE"
+        break
+    fi
+    echo "here"
+
     curl -sf localhost:8188/object_info |
         jq -c '
             to_entries |
@@ -28,7 +37,9 @@ until cat "$OUTPUTFILE" | grep ''; do
             if length > 0 then 
                 {success: true, nodes: from_entries} 
             else 
-                {success: false} 
+                {success: false, reason: "node cannot be loaded into comfy ui"} 
             end' |
-        tee "$OUTPUTFILE" 
+        tee "$OUTPUTFILE"
 done
+
+jq -e '.success' "$OUTPUTFILE"

openapi.yml

@@ -1790,6 +1790,8 @@ paths:
               properties:
                 success:
                   type: boolean
+                reason:
+                  type: string 
                 cloud_build_info:
                   $ref: '#/components/schemas/ComfyNodeCloudBuildInfo'
                 nodes:

server/implementation/registry.go

@@ -1017,7 +1017,15 @@ func (impl *DripStrictServerImplementation) CreateComfyNodes(
 	cb := mapper.ApiComfyNodeCloudBuildToDbComfyNodeCloudBuild(request.Body.CloudBuildInfo)
 	// Check if extraction was marked as unsuccessful
 	if request.Body.Success != nil && !*request.Body.Success {
+		reason := "unknown"
+		if request.Body.Reason != nil {
+			reason = *request.Body.Reason
+		}
+		log.Ctx(ctx).Warn().Msgf(
+			"Comfy nodes extraction failed for %s %s: %s", request.NodeId, request.Version, reason)
+
 		err = impl.RegistryService.MarkComfyNodeExtractionFailed(ctx, impl.Client, request.NodeId, request.Version, cb)
+
 	} else {
 		// Attempt to create comfy nodes in the registry
 		err = impl.RegistryService.CreateComfyNodes(