Chlcc screen fade#444
Merged
Merged
Conversation
This was
linked to
issues
Apr 6, 2026
Gunoshozo
force-pushed
the
chlcc-screen-fade
branch
3 times, most recently
from
April 10, 2026 14:38
362c744 to
ace7d61
Compare
Gunoshozo
marked this pull request as ready for review
April 10, 2026 15:30
Gunoshozo
commented
Apr 10, 2026
| if (GetFlag(SF_TITLEMODE)) { | ||
| Show(); | ||
| } else if (State == Shown && !IsFocused && | ||
| } else if (State == Shown && |
Contributor
Author
There was a problem hiding this comment.
!isFocused delayed the hidding of the TitleMenu until you open up SystemMenu, which in turn triggered weird state for SystemMenu and called SubItemsHide
KKhanhH
approved these changes
Apr 11, 2026
Enorovan
self-requested a review
April 11, 2026 15:31
Enorovan
approved these changes
Apr 11, 2026
Enorovan
left a comment
Enorovan
left a comment
Member
There was a problem hiding this comment.
Hella smooth loading/game start + can't reproduce the weird stuff in SystemMenu, good for me.
PringlesGang
approved these changes
Apr 11, 2026
- SubItemShow could have been called after closing a menu, when sysMenuCt == 1, SubItemsState == hidden and FocusedMenu == this
Gunoshozo
force-pushed
the
chlcc-screen-fade
branch
from
April 11, 2026 17:53
82f998b to
e0188e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.