Skip to content

Messync support and fix for a few nvl lines#487

Open
KKhanhH wants to merge 6 commits into
masterfrom
messync
Open

Messync support and fix for a few nvl lines#487
KKhanhH wants to merge 6 commits into
masterfrom
messync

Conversation

@KKhanhH

@KKhanhH KKhanhH commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@KKhanhH KKhanhH linked an issue Jun 16, 2026 that may be closed by this pull request
@KKhanhH
KKhanhH marked this pull request as ready for review June 16, 2026 08:13
@KKhanhH
KKhanhH requested review from Gunoshozo and PringlesGang and removed request for PringlesGang June 16, 2026 08:13
@KKhanhH

KKhanhH commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

Lowkey kinda human vibe coded but looks like it works and chlcc doesn't have any voiced synced lines

Comment thread src/ui/widgets/label.cpp

@Gunoshozo Gunoshozo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍💗

@PringlesGang PringlesGang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the butterfly scene, the wait icon shows on both the NVL and ADV line for MesSync, when it should only show for the ADV line

Fading also seems to be instant for sync lines when it shouldn't be

Comment thread src/vm/inst_dialogue.cpp
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
Comment thread src/vm/inst_dialogue.cpp Outdated
@KKhanhH
KKhanhH requested a review from PringlesGang July 26, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement MesSync

4 participants