C;C LCC system and title menu graphics#495
Merged
Merged
Conversation
PringlesGang
force-pushed
the
cclcc-title-graphics
branch
from
July 13, 2026 14:07
b9798a5 to
d8ee827
Compare
PringlesGang
marked this pull request as ready for review
July 13, 2026 14:26
Gunoshozo
approved these changes
Jul 16, 2026
KKhanhH
reviewed
Jul 18, 2026
Comment on lines
-587
to
-600
| ExtraItems->Render(); | ||
| } break; | ||
| case 4: { | ||
| DrawMainMenuBackGraphics(); |
Collaborator
There was a problem hiding this comment.
I'm wondering if it would make more sense if we just kept this lookup map inside title and system menu and then rendered and maybe update all the submenus in those classes. then it would be closer to what they do and we wouldn't have to put render overlay and smoke on every sub menu (just put them after the submenu render).
Member
Author
There was a problem hiding this comment.
We couldn't just render the overlay and smoke overtop the submenus, because those effects have to render behind the button guide sprite
Could still move the update and render calls over if you want tho
KKhanhH
approved these changes
Jul 21, 2026
PringlesGang
force-pushed
the
cclcc-title-graphics
branch
from
July 21, 2026 14:06
05d1cdf to
b250b08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #411
I think this PR is easiest reviewed commit-by-commit