Skip to content

Allow TokenItemAdding to invoke even if data is not string#525

Closed
kaismic wants to merge 1 commit intoCommunityToolkit:mainfrom
kaismic:TokenizingTextBox-patch1
Closed

Allow TokenItemAdding to invoke even if data is not string#525
kaismic wants to merge 1 commit intoCommunityToolkit:mainfrom
kaismic:TokenizingTextBox-patch1

Conversation

@kaismic
Copy link

@kaismic kaismic commented Oct 6, 2024

Fixes #529

PR Type

What kind of change does this PR introduce?

Other: Feature added

What is the current behavior?

See issue #5006

What is the new behavior?

See issue #5006

PR Checklist

Please check if your PR fulfills the following requirements:

  • [o] Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • [o] Based off latest main branch of toolkit
  • [o] Tested code with current supported SDKs
  • [o] Contains NO breaking changes

Other information

@kaismic
Copy link
Author

kaismic commented Oct 6, 2024

@dotnet-policy-service agree

@kaismic kaismic changed the title now TokenItemAdding invokes even if data is not string Allow TokenItemAdding to invoke even if data is not string Oct 6, 2024
@michael-hawker michael-hawker self-requested a review November 5, 2024 17:53
@michael-hawker michael-hawker self-assigned this Nov 5, 2024
@kaismic kaismic closed this by deleting the head repository May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

[Feature] TokenizingTextBox - Make TokenItemAdding event to be invoked even if the adding object is not a string to allow pre-check and cancellation

2 participants