Fix SegmentedItem visibility issue #728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // If the parent is a Segmented control with an EqualPanel, | ||
| // we need to invalidate measure to update the layout. | ||
| if ((this.Parent as Segmented)?.ItemsPanelRoot is EqualPanel panel) |
Member
There was a problem hiding this comment.
Could it just be any panel still? I can't imagine this issue would be unique to just the Equal Panel? Also, if we just invalidate our own measure, shouldn't that re-trigger the parent panel anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #726
PR Type
What kind of change does this PR introduce?
What is the current behavior?
With the
DefaultSegmentedStyle,SegmentedItemis not rendered when its visibility isCollapsedby default then toggled toVisible.What is the new behavior?
SegmentedItems are rendered when toggled toVisible.PR Checklist
Please check if your PR fulfills the following requirements:
Other information