Fix Up RHEL Builds - #129
Conversation
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
|
/packit rebuild-failed |
ddc1ae8 to
b981f87
Compare
* Move RHEL builds to build the vendor tarball manually * Reformat file to match project guidelines * Adjust spec file to build on RHEL
So that trailing white space is auto removed
b981f87 to
54c86b8
Compare
|
@Mab879 looks good. But I have one hing I would like to know your opinion on. PR #129 splits the build into a The 4 entries are still necessary, but the duplication between the How YAML anchors workYAML anchors are a core YAML feature, not something Packit-specific:
Example: - &fedora
job: copr_build
trigger: pull_request
targets: [fedora-latest-x86_64]
- <<: *fedora
trigger: commit
branch: mainThe second item resolves to: job: copr_build
trigger: commit
targets: [fedora-latest-x86_64]
branch: mainThe merge ( This is standard YAML 1.1 merge-key syntax, supported by PyYAML, Ruby's Suggested
|
|
YAML anchors usually seem a bit too clever to me. But I I'm willing to try them out there. Fun fact, when I did my own review of this PR Claude called YAML anchors "not well supported" in Packit. |
This PR splits the build into a RHEL path and Fedora path. Fedora path keeps using go-vendor-tools. RHEL manually creates the go-vendor-tools archive.