fix(web): remove stale GitHub rate-limit banner#1734
Conversation
Greptile SummaryThis PR removes the
Confidence Score: 5/5Safe to merge; the removal is consistent across all call sites and the test updates correctly reflect the new enriched-flag contract. Every reference to isPRRateLimited is gone, the new enriched-flag guard is wired identically to what was removed, and the test that previously relied on the rate-limit blocker string now uses enriched:false — which is exactly what hasMergeConflicts checks. No logic paths were left half-migrated. No files require special attention. The migration is uniform across all components.
|
| Filename | Overview |
|---|---|
| packages/web/src/lib/types.ts | Removes isPRRateLimited() and its usage in getDetailedAttentionLevel(); the unenriched guard is now the sole data-reliability gate. |
| packages/web/src/components/Dashboard.tsx | Removes rateLimitDismissed state, anyRateLimited memo, and the yellow rate-limit dismissable banner from the dashboard body. |
| packages/web/src/components/PRStatus.tsx | Removes all isPRRateLimited guards; size pill, CI badge, and review-decision chip now rely solely on isPRUnenriched to decide whether to shimmer or render. |
| packages/web/src/components/SessionCard.tsx | Removes isPRRateLimited, per-card 'PR data rate limited' chip, and rate-limit guards around isReadyToMerge, visiblePassingChecks, and alerts. |
| packages/web/src/components/SessionDetailPRCard.tsx | Removes isPRRateLimited from imports and from hasMergeConflicts; mergeability is now considered reliable whenever enriched !== false. |
| packages/web/src/components/tests/SessionDetail.mergeConflictActions.test.tsx | Updates the 'hides conflict actions when mergeability data is not reliable' test to use enriched:false instead of a rate-limit blocker string; logic is correct. |
| packages/web/src/components/session-detail-utils.ts | Removes isPRRateLimited from getCiShortLabel, getReviewShortLabel, and ciToneClass; unenriched check is now the only guard. |
| packages/web/src/components/BottomSheet.tsx | Removes isPRRateLimited from showLivePrData; reformatting only otherwise. |
| packages/web/src/components/tests/Dashboard.mobile.test.tsx | Removes the rate-limit banner show/dismiss test that exercised the now-deleted banner code. |
Reviews (1): Last reviewed commit: "fix(web): remove stale GitHub rate-limit..." | Re-trigger Greptile
1 participant
Summary
enriched === falseas the unavailable-data guard.Closes #1686.
Validation
pnpm installpnpm build(fails in this session because exportedNODE_ENV=developmentmakes Next prerender /404 with the known<Html>error)NODE_ENV=production pnpm build(passes; existing warnings for optional@composio/corein tracker-linear and one non-null assertion in terminal code)pnpm typecheckpnpm lint(passes with existing warnings)pnpm testNODE_ENV=test pnpm --filter @aoagents/ao-web test(changed component tests pass; full web suite still has unrelated existing failures inapi-routes.test.tsPR enrichment expectations andsessions/[id]/page.test.tsxmissingTestErrorBoundary)