feat(notifier): make notifier system robust with manual harness and desktop setup#1736
Draft
whoisasx wants to merge 7 commits into
Draft
feat(notifier): make notifier system robust with manual harness and desktop setup#1736whoisasx wants to merge 7 commits into
whoisasx wants to merge 7 commits into
Conversation
…en support On macOS, when terminal-notifier is installed (brew install terminal-notifier), desktop notifications now open the dashboard URL when clicked instead of opening Script Editor. Falls back to osascript when terminal-notifier is not available. New config option `dashboardUrl` controls the click-through URL: notifiers.desktop.dashboardUrl: "http://localhost:8080" Refs #1579
Contributor
Test Coverage ReportChanged files have no coverage data (not instrumented or no tests ran). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ao notify testas a manual notifier playground for realistic demo notifications without spawning sessions, starting AO, touching tmux, or creating worktrees.ao doctor --test-notifyonto the shared notifier harness with thebasictemplate.ao setup desktopfor an explicit nativeAO Notifier.appinstall/config flow.notifiers.desktop.backend: ao-app, and fallback delivery throughterminal-notifierthenosascript.executeAction(), current SDKgetEntity(...).execute(), and rawactions.execute()clients.markdown_textfield, normalizes#channelnames, and adds actionable guidance when no active Composio connection exists.Closes #1579
Test plan
pnpm --filter @aoagents/ao-notifier-macos buildpnpm --filter @aoagents/ao-plugin-notifier-desktop testpnpm --filter @aoagents/ao-plugin-notifier-composio testpnpm --filter @aoagents/ao-plugin-notifier-composio typecheckpnpm --filter @aoagents/ao-plugin-notifier-composio buildpnpm --filter @aoagents/ao-integration-tests test -- notifier-composio.integration.test.tspnpm --filter @aoagents/ao-integration-tests typecheckpnpm --filter @aoagents/ao-cli testpnpm --filter @aoagents/ao-cli test -- setup.test.tspnpm --filter @aoagents/ao-cli typecheckpnpm --filter @aoagents/ao-cli buildpnpm typecheckpnpm buildNotes
ao setup desktopis explicit; npm/global install does not silently install the macOS app.notifiers.composio.connectedAccountId/entityId.pnpm buildsucceeds with existing web build warnings for optional@composio/coreresolution intracker-linearand an existing non-null assertion warning inuseXtermTerminal.ts.