Add serde json to cbor values #826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limemloh
requested changes
Dec 3, 2025
| /// Generic CBOR data item that can represent | ||
| /// any data item type. | ||
| #[derive(Debug, Clone, PartialEq)] | ||
| #[derive(Debug, Clone, PartialEq, serde::Serialize, serde::Deserialize)] |
Contributor
There was a problem hiding this comment.
This is not a very nice json representation of the CBOR, can we avoid implementing serde on the type here? It is not really clear how it behaves, so I would move it to the application to figure out and not have to deal with it in concordium-base.
Contributor
There was a problem hiding this comment.
I agree, I don't think the CBOR value type here should be concerned with JSON serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As the
public_infotype includes cbor values that are passed as json parameters to this service, deriveserde::Serializeandserde::Deserializeoncbor::value::Value.Concordium/concordium-misc-tools#271
Changes
serde::Serializeandserde::Deserializeoncbor::value::Value.