ZKP-43 Implement serde_deprecated flag for concordium-base repo #843
Conversation
AHaliq
force-pushed
the
haliq/serde-deprecated
branch
from
ae9942b to
966b6cd
Compare
AHaliq
force-pushed
the
haliq/serde-deprecated
branch
from
966b6cd to
07508c6
Compare
| use crate::common::cbor::{cbor_decode, cbor_encode, value}; | ||
|
|
||
| /// Serialize a `HashMap<String, value::Value>` as hex-encoded CBOR. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Would it be better to put the map_hex_cbor_values module behind the feature flag instead of allowing dead code?
There was a problem hiding this comment.
I seems that this module should just be removed. Since it is not used. But would be nice with a separate PR for fixing this. So in this PR I suggest leaving the warning there. And then raise a PR to fix the warnings.
| /// | ||
| /// * A problem decoding to a group element | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
| #[allow(dead_code)] |
| /// | ||
| /// * A problem decompressing to a scalar or group element, | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
| #[allow(dead_code)] |
Same here, remove the error module in a separate PR
| } | ||
|
|
||
| /// Serialize `Bytes` as a hex string. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
It is better to put this behind a feature flag. We should very rarely need to use #[allow(dead_code)]
| } | ||
|
|
||
| /// Deserialize `Bytes` from a hex string. | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Same, use the feature flag to guard the function
| use itertools::izip; | ||
| use std::rc::Rc; | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
| #[allow(dead_code)] |
Lets keep it here for now and ignore the warning
| }, | ||
| }; | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
| #[allow(dead_code)] |
Same
allanbrondum
left a comment
allanbrondum
left a comment
There was a problem hiding this comment.
Generally looks good
DOBEN
force-pushed
the
haliq/serde-deprecated
branch
from
a42a040 to
e5928f6
Compare
Purpose
Sub task of ZKP-41. To eventually deprecate use of
serdeon non primitive data types.Changes
Guard non primitive
serde::Serialize, serde::Deserializebehind a flag. List of data types can be found hereChecklist
hard-to-understand areas.