Ar/psr 28 implement transfer #845
Open
+437
−613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanbrondum
changed the base branch from
feature/plt-scheduler-port
to
ar/cor-2097-make-cbor-serialization-infallible-2
allanbrondum
commented
Jan 8, 2026
| /// Handling [`CborMaybeKnown::Unknown`] can be used to implement forwards compatability | ||
| /// with future token operations. Unknown token operations can e.g. be ignored, if the handler is only interested | ||
| /// in specific and known token operations. | ||
| pub fn decode_operations_maybe_known( |
Contributor
Author
There was a problem hiding this comment.
The type TokenOperationsPayload cannot be moved to Rust SDK, since it is used directly in transaction payloads. So instead of allowing having operations: Vec<CborUpward<TokenOperation>> inside the type TokenOperations, I've added this method to decode to CborSerializationResult<Vec<CborMaybeKnown<TokenOperation>>>. Which allows you to decode to CborMaybeKnown, which gives you the flexibility to handle unknown variants if you want.
allanbrondum
commented
Jan 8, 2026
| /// transaction. | ||
| #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct TokenModuleRejectReason { |
Contributor
Author
There was a problem hiding this comment.
Will be moved to Rust PLT scheduler and to Rust SDK as separate types
Base automatically changed from
ar/cor-2097-make-cbor-serialization-infallible-2
to
feature/plt-scheduler-port
January 9, 2026 09:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement
concordium_basepart of https://linear.app/concordium/issue/PSR-20/remove-upward-from-base-and-copy-plt-cbor-types-to-the-sdk.Changes
Upwardtype (to be moved to Rust SDK)TokenModuleRejectReasonandTokenEvent. They are to be copied to Rust SDK and to the Rust PLT scheduler as separate types.Checklist
hard-to-understand areas.