Skip to content

Conversation

@drsk0
Copy link
Contributor

@drsk0 drsk0 commented Oct 24, 2024

Purpose

Set stake to zero of suspended validators.

Changes

As described above. To facilitate the change, a suspended flag and validator id field are added to ActiveBakerInfo.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@drsk0 drsk0 force-pushed the suspension_via_compute_baker_stakes_and_capital branch from b98a398 to 0af9b4d Compare October 24, 2024 12:37
@drsk0 drsk0 requested a review from td202 October 28, 2024 09:13
@drsk0 drsk0 force-pushed the suspension_via_compute_baker_stakes_and_capital branch 5 times, most recently from 32bb222 to 583aa69 Compare November 13, 2024 14:17
@drsk0 drsk0 marked this pull request as ready for review November 13, 2024 14:27
@drsk0
Copy link
Contributor Author

drsk0 commented Nov 13, 2024

Tests are missing at the moment, is there a good place to add them @td202 ?

@drsk0 drsk0 requested a review from td202 November 13, 2024 14:28
@td202
Copy link
Contributor

td202 commented Nov 14, 2024

Tests are missing at the moment, is there a good place to add them @td202 ?

Probably either in EpochTransition, if they fit there, or else add a new test file (probably in SchedulerTests).

@drsk0 drsk0 force-pushed the suspension_via_compute_baker_stakes_and_capital branch 2 times, most recently from f51b843 to 7f26bd1 Compare November 14, 2024 18:35
@drsk0 drsk0 requested a review from td202 November 18, 2024 16:01
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drsk0 drsk0 force-pushed the suspension_via_compute_baker_stakes_and_capital branch from 8bbf029 to 2242cb2 Compare November 19, 2024 16:59
@drsk0 drsk0 force-pushed the suspension_via_compute_baker_stakes_and_capital branch from 79ae971 to 9f2b7f6 Compare November 19, 2024 17:05
@drsk0 drsk0 merged commit 4a2e7b8 into main Nov 19, 2024
3 checks passed
@drsk0 drsk0 deleted the suspension_via_compute_baker_stakes_and_capital branch November 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants