-
Notifications
You must be signed in to change notification settings - Fork 25
suspension via computeBakerStakesAndCapital #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b98a398 to
0af9b4d
Compare
td202
reviewed
Nov 5, 2024
32bb222 to
583aa69
Compare
Contributor
Author
|
Tests are missing at the moment, is there a good place to add them @td202 ? |
drsk0
commented
Nov 13, 2024
concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/LeaderElectionTest.hs
Show resolved
Hide resolved
Contributor
Probably either in EpochTransition, if they fit there, or else add a new test file (probably in |
td202
requested changes
Nov 14, 2024
f51b843 to
7f26bd1
Compare
drsk0
commented
Nov 18, 2024
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
td202
reviewed
Nov 19, 2024
td202
approved these changes
Nov 19, 2024
Contributor
td202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
concordium-consensus/tests/scheduler/SchedulerTests/KonsensusV1/EpochTransition.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/scheduler/SchedulerTests/KonsensusV1/EpochTransition.hs
Outdated
Show resolved
Hide resolved
8bbf029 to
2242cb2
Compare
…1/EpochTransition.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]>
79ae971 to
9f2b7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Set stake to zero of suspended validators.
Changes
As described above. To facilitate the change, a suspended flag and validator id field are added to
ActiveBakerInfo.Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.