test: handle gnark-crypto not returning malleable signatures anymore #1601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Consensys/gnark-crypto#725 gnark-crypto prevents returning ECDSA signatures with large s (>(mod-1)/2), but we're testing the mismatch case in the precompile tests here.
Handle it manually now and explicitly create large s in tests.
This PR currently depends on a gnark-crypto branch as the change isn't merged yet. When corresponding gnark-crypto PR is merged then also should update dependency here to gnark-crypto@master.
Type of change
How has this been tested?
Checklist:
golangci-lint
does not output errors locally