Skip to content

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Sep 10, 2025

Description

In Consensys/gnark-crypto#725 gnark-crypto prevents returning ECDSA signatures with large s (>(mod-1)/2), but we're testing the mismatch case in the precompile tests here.

Handle it manually now and explicitly create large s in tests.

This PR currently depends on a gnark-crypto branch as the change isn't merged yet. When corresponding gnark-crypto PR is merged then also should update dependency here to gnark-crypto@master.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • TestECRecoverCircuitShortMismatch

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub self-assigned this Sep 10, 2025
@ivokub ivokub added the type: bug Something isn't working label Sep 10, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@ivokub ivokub marked this pull request as draft September 10, 2025 13:27
@ivokub ivokub mentioned this pull request Sep 10, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant