fix: failing lookup for inactive function call #1160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a notion of an enable line to an io.Bus. This allows the bus to be enabled or disabled, as required. However, at this stage, the enable line is never filled during trace expansion with anything other than 0. Furthermore, no constraints are added to enforce its one at certain positions.
Bus enable lines are now operational. There remains some opportunity for optimisation. For example, if every function had at least one instance then we could always fill the bus with useful values from the outset, thereby avoid the need for the enable line altogether. This also prevents I/O lines from being included in constancy constraints. Such lines can only be read at the point of use, and therefore it doesn't matter what happens after this.
DavePearce
force-pushed
the
1151-fix-failing-lookup-for-inactive-function-call
branch
from
6b3b2a1 to
300bfd5
Compare
DavePearce
deleted the
1151-fix-failing-lookup-for-inactive-function-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.