feat: Multichain #961
feat: Multichain #961
Conversation
|
|
1 similar comment
|
|
alainncls
force-pushed
the
feat/multichain
branch
from
c1df65c to
212d268
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #961 +/- ##
==========================================
- Coverage 52.73% 49.25% -3.49%
==========================================
Files 19 23 +4
Lines 402 536 +134
Branches 61 77 +16
==========================================
+ Hits 212 264 +52
- Misses 184 261 +77
- Partials 6 11 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alainncls
force-pushed
the
feat/multichain
branch
from
212d268 to
9992948
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } = useSWR(`${SWRKeys.GET_ATTESTATION_BY_ID}/${id}`, fetchAttestation, { | ||
| shouldRetryOnError: false, | ||
| revalidateOnFocus: false, | ||
| }); |
There was a problem hiding this comment.
Bug: SWR Cache Keys Missing Network Dependency
The SWR cache keys in both SearchAttestationsReceived and Attestation components don't include networkType as a dependency. This means that when the network type changes, SWR might return cached data from a different network, leading to stale or incorrect information being displayed.
Additional Locations (1)
| network: <LineaMainnetIconDark />, | ||
| id: ZERO_ADDRESS, | ||
| moduleAddress: ZERO_ADDRESS, | ||
| name: NetworkName.LINEA, |
There was a problem hiding this comment.
Bug: Mock Module Type Mismatch
The skeletonModules function generates mock Module objects with incorrect types. It adds a network property (a React component) and assigns the name property an enum value, neither of which align with the Module interface. This type mismatch may lead to TypeScript errors and runtime issues.
|
|
||
| return this.executeReadMethod(functionName, args); | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: Cross-Chain Read Method Targets Incorrect Chain
The executeReadMethodForChain method resolves the correct contract address for a given chain, but then calls executeReadMethod which uses this.conf.attestationRegistryAddress. This causes cross-chain read operations to incorrectly target the current instance's chain.
What does this PR do?
Related ticket
Fixes issues:
Type of change
Check list
Note
Introduces multichain querying across Linea/Arbitrum/Base/BSC via GraphQL Mesh, adds
chainNameandfindByMultiChainAPIs, updates schema/resolvers, examples, tests, and build/deps.ChainNameenum; exposefindByMultiChainforattestation,portal,schema,moduleand map results includingchainName.Attestation,Portal,Schema,Module) with optionalchainName.{context.chainName}; add Yoga persisted operations.chainNamefields and new queries:multichainAttestations/Portals/Schemas/Modules.queries.graphql,.graphclientupdates).findByMultiChainexamples for all entities; update CLI docs.scripts/fix-imports; set packagebrowserfield.Written by Cursor Bugbot for commit 9992948. This will update automatically on new commits. Configure here.