feat: enable build for zkevm.go.bin
#559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This adds a new target for constructing a `zkevm.gob` using `go-corset`. For now, we use `zkevm.gob` until things have stablised and we can return to the `zkevm.bin` format as before.
For reasons unknown, there was a `defalias` instance embedded into a `defperspective` declaration. This syntax is not supported by `go-corset` (and its unclear whether the original tool supports it even). Eitherway, since this alias is not used, it can be safely removed.
A defpurefun selector function was being declared in the top-level module, and which used qualified names to access columns directly in the bin module. This should have actually been reported as a syntax error. Instead, defun should be used and this changes it accordingly.
This comments out some broken debug constraints.
This adds necessary type information for the `bit_n` parameter which is passed in to the `plateau-constraints` library function.
This fixes a bunch of typos, mostly where the given perspective for a column was not correctly specified. This is actually quite a serious error, because it seems corset has a problem with columns in different perspectives that have the same name.
This adds a corresponding target `zkevm_for_reference_tests.go.bin` to be used when running the reference tests.
The rough fix made for the `ecdata/constraints` was incorrect, and this now fixes it.
DavePearce
force-pushed
the
556-feat-integrate-go-corset
branch
from
a2c18b7 to
051db4f
Compare
This places the relevant constants for Linea or Ethereum into the relevant file in the blockdata/processing/gaslimit directory. These are then picked up correctly by the `Makefile`.
Signed-off-by: Olivier Bégassat <[email protected]>
Signed-off-by: Olivier Bégassat <[email protected]>
OlivierBBB
reviewed
Jan 13, 2025
OlivierBBB
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a new build target, namely
zkevm.go.bin. This target is built usinggo-corsetrather than the originalcorsettool. In order to make this work, a very small number of fixes to the constraints were required. These consist of simple typos and/or broken debug constraints.