Skip to content

Conversation

@OlivierBBB
Copy link
Collaborator

@OlivierBBB OlivierBBB commented Oct 27, 2025

Note

Major ROM spec rewrite introducing romColumn-based columns, explicit padding/limb machinery, revised PUSH/JUMPDEST flags and lookups, plus macro and version updates.

  • ROM module (spec/docs):
    • Column schema: Replace legacy columns with romColumn* namespace (ROM code/PC/limb/opcode, push counters/values, padding, empty/nonempty, done, CFI/CFI_MAX, sizes, indices).
    • Padding/byte code: Add explicit byte code padding rules; new diagrams (lua/*.tex) and a dedicated Byte code section.
    • Constraints: Rework and expand constancy/binarity, CT/CT_MAX, program counter, padding, limb accumulation/size/index, CFI/CFI_MAX, heartbeat, vanishing, and end-of-CFI conditions.
    • Opcode/PUSH handling: Derive romColumnOpcode from raw limb bytes; introduce romColumnOpcodeIsPush, romColumnOpcodeIsJumpDest, and romColumnClaimedByPush; rebuild PUSH counters/values and funnel-bit logic.
    • Instruction decoding lookup: Update lookup to use romColumnOpcode, romColumnOpcodeIsPush, and IJD; tables now parametrize by evmWordSize.
    • Intro/convention: Clarify supported events and PUSHX scope (X ∈ {1..evmWordSize}, excluding PUSH0).
  • Lookups (HUB → ROM):
    • Target column switched from IS_VALID_JUMP_DESTINATION to opcodeIsJumpDest.
  • Styling/macros:
    • pkg/rom.sty: Rename fields (e.g., CODE_SIZE, CODE_SIZE_REACHED), add all romColumn* macros, and standardized opcode flags.
    • pkg/common.sty: Tweak \false rendering to <faux>; minor color macro tweak in local ROM.
    • rom/_all_rom.tex: Use fleqn; include system and iomf_done packages.
  • Versions:
    • Normalize version files to just backticked names for rom_v3, mxp_v2, and rlp_txn_v2.

Written by Cursor Bugbot for commit 571e33b. This will update automatically on new commits. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants