optimism deposit transaction

[thinkAfCod]

PR description

Added the deposit transaction type, along with the related encoders and decoders.

[matkt]

there is no library we can use for that ? or maybe push this class in an utility class or tuweni ?

[thinkAfCod]

I have only found implementations of FLZ compression in Netty and jfastlz, but they only provide encode/decode methods and do not offer a way to directly calculate the compressed length.

This flzCompressLength method is my Java implementation translated from the one in the op-alloy-flz repository.

It only calculates the length of the compressed data without performing the actual compression.

And it will only be used when creating an instance of RollGasData.

I think it might be more appropriate to move it to a utility class separately.

[matkt]

Yes I think we can move it to a utility class , thanks

[matkt]

idk if it will be easy but I will prefer to have another transaction type list for optimism in order to see more easilty the type of transaction by network

[matkt]

did you had time to look at this point ?

[matkt]

same here I will prefer to separate as much as possible mainnet code and layer 2 code. I think it will also simplify the next step when we will want to push this code in a plugin

[matkt]

example OptimismTransactionDecoder implement TransactionDecoder
example MainnetTransactionDecoder implement TransactionDecoder

and something similar for the other classes

[thinkAfCod]

LGTM

[thinkAfCod]

I created two new interfaces: TransactionEncoder.EncoderProvider and TransactionDecoder.DecoderProvider, which are used to obtain the encoder and decoder, respectively.

The encoder list and decoder list are maintained in OptimismTransactionEncoderDecoderProvider and MainnetTransactionEncoderDecoderProvider.

TransactionEncoder and TransactionDecoder use MainnetTransactionEncoderDecoderProvider by default.

[garyschulte]

If this unit test fails a 4th time, it likely is not a flaky test:

TransactionPoolOptionsTest > maxPrioritizedTxsPerTypeWrongTxType() FAILED
    java.lang.AssertionError at TransactionPoolOptionsTest.java:415

[thinkAfCod]

I found it and I'm trying to fix the issue with the unit test failure.

[thinkAfCod]

This PR is valid now, could be merged.

[matkt]

really like the last modification just asked one more question regarding the TransactionType enum

[matkt]

did you had time to look at this point ?

[thinkAfCod]

Below is an example of the modification:

Extract TransactionType into an interface.

public interface TransactionType {

  boolean isFrontier();

  boolean isBlob();

  boolean isAccessList();

  boolean isDelegateCode();

  int getTypeValue();

  Set<TransactionType> getAccessListSupportedTransactionTypes();

  Set<TransactionType> getLegacyFeeMarketTransactionTypes();
}

TransactionType will implement this interface：

public enum MainnetTransactionType implements TransactionType {
  /** The Frontier. */
  FRONTIER(0xf8 /* this is serialized as 0x0 in TransactionCompleteResult */),
  /** Access list transaction type. */
  ACCESS_LIST(0x01),
  /** Eip1559 transaction type. */
  EIP1559(0x02),
  /** Blob transaction type. */
  BLOB(0x03),
  /** Eip7702 transaction type. */
  DELEGATE_CODE(0x04);
  
  // implement the TransactionTypeInfo interface...  
}

Also OptimismTransactionType will implement TransactionType interface too:

public enum OptimismTransactionType implements TransactionType {
  /** The Frontier. */
  FRONTIER(0xf8 /* this is serialized as 0x0 in TransactionCompleteResult */),
  /** Access list transaction type. */
  ACCESS_LIST(0x01),
  /** Eip1559 transaction type. */
  EIP1559(0x02),
  /** Blob transaction type. */
  BLOB(0x03),
  /** Eip7702 transaction type. */
  DELEGATE_CODE(0x04),
  /** Optimism Deposit transaction type. */
  OPTIMISM_DEPOSIT(0x7e);
  
  // implement the TransactionType interface...  
}

Since many places directly reference the FRONTIER enumeration type in MainnetTransactionType, it may be necessary to add an additional TransactionTypeProvider type to obtain the actual enumeration values instead of directly referencing the enumeration type.

Even so, there are probably over 100 files that need to be modified.