Fix: shomei use block tracer on eth simulate to support trielog filtering#165
Draft
garyschulte wants to merge 4 commits intoConsensys:mainfrom
Draft
Fix: shomei use block tracer on eth simulate to support trielog filtering#165garyschulte wants to merge 4 commits intoConsensys:mainfrom
garyschulte wants to merge 4 commits intoConsensys:mainfrom
Conversation
Signed-off-by: garyschulte <[email protected]>
…ed overload Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
fix/shomei-use-block-tracer-on-eth-simulate
branch
from
634dc83 to
d9976fe
Compare
matkt
reviewed
Apr 14, 2026
| final TrieLogLayer trieLogLayer = | ||
| worldStateArchive.getTrieLogLayerConverter().decodeTrieLog(RLP.input(trieLogBytes)); | ||
| worldStateArchive.getTrieLogLayerConverter().decodeTrieLog( | ||
| RLP.input(trieLogBytes), optWorldState.get().getZkEvmWorldStateStorage()); |
Collaborator
There was a problem hiding this comment.
why we need to pass the worldstatestorage and not use the one we are passing in the constructor here https://github.com/Consensys/shomei/pull/165/changes#diff-4f07a7333cca9e86a5e0c552d5e21a36b4af014b7eec54b7071a127d70b79375R51
Contributor
Author
There was a problem hiding this comment.
because the trielog being generated needs to be against its parent, not necessarily the head worldstate. Like if we are trying to generate a trielog for a forced transaction that is n blocks back, we cannot use the head worldstate to validate prior values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR builds on #164 , besu #10211 and besu-shomei-plugin #82
This should merge last in that chain, and will need to be rebased once #164 merges.
This PR adds a
traceBlockImportparameter to the eth_simulateV1 call, which will cause besu to use (if configured) the zkTracer during forced transaction simulationrollup_getVirtualZkEVMStateMerkleProofV1Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes the
eth_simulateV1request shape and the trielog decoding path used to build virtual proofs, which can affect correctness of generated traces/proofs if mismatched with Besu/plugin behavior.Overview
Updates the Besu
eth_simulateV1client request to include a newtraceBlockImportflag, enabling block-import tracing during forced transaction simulation.Adjusts virtual proof generation (
rollup_getVirtualZkEVMStateMerkleProofV1) to decode the returned trielog against the cached parent blockWorldStateStorage, and refactorsTrieLogLayerConverterto accept an explicit storage instance (instead of always using head state) when resolving prior account/storage values.Reviewed by Cursor Bugbot for commit 634dc83. Bugbot is set up for automated code reviews on this repo. Configure here.