More test samples for dominators #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks for better readability.
blitz-1306
commented
Nov 22, 2023
There was a problem hiding this comment.
I expected this file to have more thorough output, respecting InheritanceSpecifiers. I think part of the issue is that we did not yet fully handle constructor invocations in dominateStmt:
Also, I'm not sure if the should actually be handled in dominateStmt. Still, at least order of modifier invocations, respecting inherited base constructors (if they are invoked), should be considered in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
This PR partially addresses #10.
Changes
Regards.