Process execution payload #9112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add missing test spec config
* fix spec config
* fix Focil spec loader
* fix acceptance tests
* add inclusion list containers
* add signed inclusion list gossip layer
* add inclusion list pool skeleton
* Merge branch master
* implement inclusion list by committee indices rpc logic
…fy-new-payload # Conflicts: # ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/inclusionlist/InclusionListManager.java
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
|
do you really want to merge this on master? :) |
| @@ -60,7 +63,8 @@ BeaconState processAndValidateBlock( | |||
| SignedBeaconBlock signedBlock, | |||
| BeaconState blockSlotState, | |||
| IndexedAttestationCache indexedAttestationCache, | |||
| Optional<? extends OptimisticExecutionPayloadExecutor> payloadExecutor) | |||
| Optional<? extends OptimisticExecutionPayloadExecutor> payloadExecutor, | |||
| Function<SlotAndBlockRoot, Optional<List<InclusionList>>> inclusionListSupplier) | |||
There was a problem hiding this comment.
Is there a reason for using a supplier here? We could directly get the ILs as Optional<List<InclusionList>> from the store since we have the slot and block root when running a fork choice on a block (the ForkChoice::onBlock has the slot and the block root
There was a problem hiding this comment.
So my choice to use the supplier here was more in terms of making sure that we only try to fetch the IL when we're assembly the payload, but I think at this stage the block has been already formed so yeah we can probably just retrieve the IL at ForkChoice::onBlock. Thanks for the review
mehdi-aouadi
approved these changes
Feb 12, 2025
…using supplier Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
# Conflicts: # ethereum/spec/src/main/java/tech/pegasys/teku/spec/logic/versions/eip7805/block/BlockProcessorEip7805.java
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR was built on top of #9111
Adds a new validation to the ProcessExecutionPayload to ensure that the number of tx in the IL in no larger than the number defined in the spec.
Fixed Issue(s)
Part of #8937
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog