fix(cache): show details for verbose size#346
Open
OnlyYu1996 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PlatformNetwork/bounty-challenge#53106.
Changes:
--verboseflag into the cache command handler.cortex cache sizeoutput as the single human-readable size line.cache sizedetails: cache directory, existence, total item count, and per-category size/item/path rows.cortex --verbose cache size --json, while preserving the existing compact JSON shape for non-verbose JSON.Validation:
cargo +stable fmt --package cortex-cli --checkcargo +stable test --package cortex-cli cache_cmd::tests::test_cache_size_verbose -- --nocapturecargo +stable check --package cortex-cli --libcargo +stable build --package cortex-cli --bin Cortextarget/debug/Cortex.exe cache size --color nevervstarget/debug/Cortex.exe --verbose cache size --color neverare no longer identical; verbose output includes cache directory and categories.git diff --check