-
Notifications
You must be signed in to change notification settings - Fork 295
Server configuration #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server configuration #463
Conversation
feat: remove enableServerConfiguration
refactor: internal limits checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
sdk/src/main/java/ly/count/android/sdk/ConnectionQueue.java:198
- Ensure that wrapping the location data addition within a configProvider check does not omit necessary data when location tracking is intentionally disabled; if this is the desired behavior, consider adding a comment to clarify the logic.
if (configProvider.getLocationTrackingEnabled()) {
sdk/src/androidTest/java/ly/count/android/sdk/TestUtils.java:477
- Renaming from getCountyStore() to getCountlyStore() improves consistency; please confirm that all references across tests have been updated accordingly.
protected static CountlyStore getCountlyStore() {
sdk/src/androidTest/java/ly/count/android/sdk/ModuleAPMTests.java:265
- [nitpick] Verify that the truncation of the trace key from 'a_trace_to_track' to 'a_tra' aligns with the intended key length limit in the server configuration and is consistent throughout the SDK.
String key = "a_trace_to_track";
sdk/src/androidTest/java/ly/count/android/sdk/ConnectionProcessorTests.java:81
- Double-check that overriding getSessionTrackingEnabled() to return false in the test configuration aligns with the intended session tracking behavior, as this may affect related session logic.
@Override public boolean getSessionTrackingEnabled() {
No description provided.