Skip to content

Server configuration #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Apr 15, 2025
Merged

Server configuration #463

merged 60 commits into from
Apr 15, 2025

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

@arifBurakDemiray arifBurakDemiray marked this pull request as draft February 12, 2025 08:12
Copy link

github-actions bot commented Feb 12, 2025

Unit Test Results 🚀

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 9a1b239. ± Comparison against base commit 92def04.

♻️ This comment has been updated with latest results.

@arifBurakDemiray arifBurakDemiray marked this pull request as ready for review February 13, 2025 12:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 36 out of 36 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

sdk/src/main/java/ly/count/android/sdk/ConnectionQueue.java:198

  • Ensure that wrapping the location data addition within a configProvider check does not omit necessary data when location tracking is intentionally disabled; if this is the desired behavior, consider adding a comment to clarify the logic.
if (configProvider.getLocationTrackingEnabled()) {

sdk/src/androidTest/java/ly/count/android/sdk/TestUtils.java:477

  • Renaming from getCountyStore() to getCountlyStore() improves consistency; please confirm that all references across tests have been updated accordingly.
protected static CountlyStore getCountlyStore() {

sdk/src/androidTest/java/ly/count/android/sdk/ModuleAPMTests.java:265

  • [nitpick] Verify that the truncation of the trace key from 'a_trace_to_track' to 'a_tra' aligns with the intended key length limit in the server configuration and is consistent throughout the SDK.
String key = "a_trace_to_track";

sdk/src/androidTest/java/ly/count/android/sdk/ConnectionProcessorTests.java:81

  • Double-check that overriding getSessionTrackingEnabled() to return false in the test configuration aligns with the intended session tracking behavior, as this may affect related session logic.
@Override public boolean getSessionTrackingEnabled() {

@turtledreams turtledreams merged commit 545f245 into staging Apr 15, 2025
3 of 5 checks passed
@turtledreams turtledreams deleted the server_config branch April 15, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants