-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New class structure and names, and example #7
Conversation
Things I'd particularly appreciate input on: Do you think it's okay to have that .xyz file in the examples folder? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
examples/example_xyz.py
Outdated
|
||
# set up the Countoscope | ||
countoscope = Countoscope( | ||
trajectory_file = 'trajectory2.xyz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be trajectory_file = 'trajectory.xyz' (without the 2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, thanks
@adamrobcarter feel free to merge. Then I suppose we can start working in parallel on some of the stuff we were planning to implement. |
Its fine for now. In the future, we will have a documentation too, so then we can decide if we want to keep a documentation + an example folder. But for now, I think that its super important that we have it as it is, because other users need to know how to deal with the code. |
Okay, I'll merge. First thing I'll work on will be data coming directly from numpy, then I'll do variable box/separation sizes |
Changes as discussed 10/09/24, also added an example.
Please let me know any comments or feedback!