Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New class structure and names, and example #7

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

adamrobcarter
Copy link
Contributor

@adamrobcarter adamrobcarter commented Sep 11, 2024

Changes as discussed 10/09/24, also added an example.

Please let me know any comments or feedback!

@simongravelle simongravelle self-assigned this Sep 11, 2024
@adamrobcarter
Copy link
Contributor Author

Things I'd particularly appreciate input on:

Do you think it's okay to have that .xyz file in the examples folder?
Do you think the example looks okay?

Copy link
Member

@simongravelle simongravelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.


# set up the Countoscope
countoscope = Countoscope(
trajectory_file = 'trajectory2.xyz',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be trajectory_file = 'trajectory.xyz' (without the 2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks

@simongravelle
Copy link
Member

@adamrobcarter feel free to merge. Then I suppose we can start working in parallel on some of the stuff we were planning to implement.

@simongravelle
Copy link
Member

Things I'd particularly appreciate input on:

Do you think it's okay to have that .xyz file in the examples folder? Do you think the example looks okay?

Its fine for now.

In the future, we will have a documentation too, so then we can decide if we want to keep a documentation + an example folder. But for now, I think that its super important that we have it as it is, because other users need to know how to deal with the code.

@adamrobcarter
Copy link
Contributor Author

Okay, I'll merge. First thing I'll work on will be data coming directly from numpy, then I'll do variable box/separation sizes

@adamrobcarter adamrobcarter merged commit fc810aa into develop Sep 11, 2024
1 check passed
@adamrobcarter adamrobcarter deleted the new_structure_and_names branch September 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants