Skip to content

Graph parse bug #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

yoonieaj
Copy link
Contributor

@yoonieaj yoonieaj commented Jul 28, 2025

Proposed Changes

This PR fixes a bug where parsing all pre-generated graphs (i.e., course graphs) would fail.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link

coveralls commented Jul 28, 2025

Pull Request Test Coverage Report for Build 09f59d88-cdbb-41f9-96fd-9405ba67320e

Details

  • 17 of 20 (85.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 54.119%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Svg/Parser.hs 17 20 85.0%
Totals Coverage Status
Change from base Build fd49a1b4-f6ed-440a-ae12-ad2cbdc17a11: -0.02%
Covered Lines: 2105
Relevant Lines: 3891

💛 - Coveralls

@yoonieaj yoonieaj marked this pull request as ready for review July 28, 2025 02:19
@yoonieaj yoonieaj requested a review from david-yz-liu July 28, 2025 02:19
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonieaj this change is good, but please update the PR description and Changelog to be more descriptive about the specific bug that this is fixing. I.e., what types of SVG text structure is being supported now that wasn't previously supported?

@yoonieaj yoonieaj requested a review from david-yz-liu August 15, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants