Fixing Issue #8056 Item Stack Limitation#8076
Closed
tanayvsoni wants to merge 2 commits into
Closed
Conversation
Member
|
Thanks, I've implemented a alternative fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the inventory a stock network was trying to access had stacks of any item which could hold more then the original vanilla stack limit for the item, then the stock network would not recognize any item over the item within the stack.
Issue was occurring due to using the vanilla ItemStack class initially to scan the item. I fixed it by figuring out the count of the item before they are added to the InventorySummary and then adding them via one of the existing add functions which will make the ItemStack into a BigItemStack.
To figure out the count I made a duplicate of the target inventory as a ItemStackHandler and then looped over this under the ItemStack had no items remaining. I could not use any built in functions in ItemStack as they were limited to the max stack size.