Threshold switch improvements #8097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klisz
commented
Mar 23, 2025
Klisz
commented
- Closes Quantity error when threshold switch checks Mekanism's fluid tanks' liquid reserves #8074 by adding block tags for blocks whose block entities have item/fluid capabilities, but whose items/fluids respectively should not be measured by threshold switches (principally for those that can contain both). The Mekanism fluid tanks that the issue was originally opened for are added to the ignore-items tag.
- Allows ThresholdSwitchObservable implementations to define an override for the value step, similarly to how they already can override the formatting.
Implements my proposed fix for Creators-of-Create#8074
Allows ThresholdSwitchObservables to override the value step much like they already can for the formatting
adaliszk
reviewed
Mar 24, 2025
Comment on lines
+168
to
+170
| TagGen.addOptional(prov.tag(AllBlockTags.THRESHOLD_SWITCH_IGNORE_ITEMS.tag), Mods.MEK, | ||
| List.of("basic_fluid_tank", "advanced_fluid_tank", "elite_fluid_tank", "ultimate_fluid_tank")); | ||
|
|
There was a problem hiding this comment.
Could this not be done from the json file if that contains the mod separately? That way it could be Open-Close by letting people edit the JSON file which should be possible to target with datapacks, or not?
There was a problem hiding this comment.
This method is called as part of the process of generating the datapack json files, and shouldn't run anywhere else.
There was a problem hiding this comment.
I see, so it is the other way around. The JSON file was generated from this.
adaliszk
added
area: compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.