Change Wrench checks in Create code to use a tag rather than a hardcoded item #8566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techno-sam
suggested changes
Jun 12, 2025
...mibubi/create/foundation/blockEntity/behaviour/edgeInteraction/EdgeInteractionBehaviour.java
Outdated
Show resolved
Hide resolved
...simibubi/create/foundation/blockEntity/behaviour/edgeInteraction/EdgeInteractionHandler.java
Outdated
Show resolved
Hide resolved
...imibubi/create/foundation/blockEntity/behaviour/edgeInteraction/EdgeInteractionRenderer.java
Outdated
Show resolved
Hide resolved
|
This needs to be adjusted now that #9165 is merged (achieved part of this in a slightly different manner) |
|
@vercte, this pull request has merge conflicts with the target branch. Please merge the latest changes and leave a message here so we can continue with the process of reviewing and merging this pull request. Thanks! |
|
i did it. i think. git is weird |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes hard-coded wrench code to check for the new CREATE_WRENCH (
create:wrench) tag, replacing the previous forge tag with FORGE_WRENCH (forge:tools/wrench) for distinction, keeping old behaviorIt also modifies EdgeInteractionBehaviour to use an ItemStack predicate instead of just a single item for more versatility, which is necessary to make this carry out its full purpose. The old function for adding an item to it is still valid and can be used the same in addons.