Fix proposal for #6076 #9256
Fix proposal for #6076 #9256
Conversation
Allmoz
force-pushed
the
schemati_lag
branch
from
e88a880 to
cb0d59b
Compare
|
This fixes #4398 by extension. This hover text should be adjusted when you're blocked from putting a schematic there, imo. |
VoidLeech
added
pr type: fix
Then probably a proper method to check if can insert would be in order. I'm not very familiar yet with mc UIs, any advice/recommendation? |
| private final String _slotGunpowder = "gui.schematicannon.slot.gunpowder"; | ||
| private final String _slotListPrinter = "gui.schematicannon.slot.listPrinter"; | ||
| private final String _slotSchematic = "gui.schematicannon.slot.schematic"; | ||
| private final String _slotSchematicEnabled = "gui.schematicannon.slot.schematic"; |
There was a problem hiding this comment.
Should I migrate it to "gui.schematicannon.slot.schematicEnabled"? is enough just changing the id?
Allmoz
force-pushed
the
schemati_lag
branch
from
89e4a4a to
395f38a
Compare
|
Ok, ready to review, I hope renaming a lang entry is not a bad thing |
If a key is renamed then it should also be changed in the other lang files so that the existing translations aren't lost. |
|
Done |
As well explained by the user that made #6076, when the schematic is out of range the cannon gets reseted as in all other errors, but the schematic is not emptied or moved from slot 0, so it immediately gets reloaded, over and over again.
Since the other schematics error also have the issue of voiding previous stack of schematics on the output, and on finish schematics get overstacked, this PR makes so that only 1 schematic can be in the canon at once by:
I would like a visual indication that the slot 0 is disabled (like when it has an schematic in it), but I don't know how to do that yet .