-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth: add onLoginSuccess callback #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42af24f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
alfonso-paella
approved these changes
Feb 15, 2025
Destiner
added a commit
that referenced
this pull request
Feb 25, 2025
* fix(smart-wallet): lint * refactor(smart-wallet): clean up * feat(smart-wallet)!: init rewrite * remove all code * use API * wallet creation & tx sending for ECDSA signers * clean up dependencies * auth: twitter user type (#910) * auth user type: twitter * changeset * chore(smart-wallet): install ox * feat(smart-wallet): passkey signer * wallet creation * transaction sending flow * feat(smart-wallet): signatures * `signMessage` * `signTypedData` * feat(smart-wallet): implement `getNonce` * feat(smart-wallet): add transferToken, nfts, executeContract * refactor(smart-wallet): format * fix(smart-wallet): export EVMSmartWallet * fix(smart-wallet): specify chain when querying NFTs * fix(smart-wallet): remove unused file * chore(smart-wallet): bump version * Auth: Adapts server sdk to non-nodejs envs and adds example to next auth app (#912) * Adapts server sdk to non-nodejs envs and adds example to next auth app with middleware * pnpm lock * Release packages (#911) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(smart-wallet): use /me endpoints * fix(smart-wallet): throttle status requests * fix(smart-wallet): exports * feat(smart-wallet): passkey credential creation * docs(smart-wallet): add README * docs(smart-wallet): README fixes * docs(smart-wallet): README edits * fix(smart-wallet): remove custom errors from docs * fix(smart-wallet): improve API response schema * feat(smart-wallet): custom errors * chore(smart-wallet): changesets * docs(smart-wallet): migration guide * feat(smart-wallet): implement writeContract * fix(smart-wallet): null checks * Auth: Improve janky animations and UX (#917) * Auth: Improve janky animations and UX * added changeset * Release packages (#918) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * pay-with-crypto: better handle scenarios when chain not supported (#916) * pay-with-crypto: better handle scenarios when chain not supported * changeset * requested change * lint * asd * asd * Release packages (#919) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add Story testnet (#914) * docs(smart-wallet): update README * fix(smart-wallet): revert package version this will be updated automatically * fix(smart-wallet): group changesets * fix(smart-wallet): use CrossmintApiClient * fix(smart-wallet): move types to a separate file * fix(smart-wallet): move types into a separate file * fix(react-ui): use latest smart wallet SDK * fix: format * fix: update changeset * order: update type (#923) * save * changeset * Release packages (#924) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * embedded-props: add execution parameters (#920) * embedded-props: add execution parameters * changeset * adding token locator * lint * lint * reset * lint * adjustment * Release packages (#925) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chain: add Chiliz (#926) * chain: add Chiliz * lint * changeset * Release packages (#927) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Wallet Demo: Updated verbiage (#928) * SmartWalletsSDK: add Story testnet (#930) * SmartWalletsSDK: add Story testnet * double quotes * linthappy * minor * Auth: Optionally dont throw when cookies not found (#929) * Dont throw unhandled errors if cookies not found in req when expected in the body * changes * fixes pr comments * fix build * auth: initializing status (#932) * save * change * Release packages (#931) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * embedded: fixing embedded checkout types for line items (#933) * embedded: fixing embedded checkout types for line items * asd * Release packages (#934) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: stale JWT re-render bug (#935) * Fix: stale JWT re-render bug * added changeset * Release packages (#936) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Story: add mainnet (#938) * Story: add mainnet * fixlint * fixlint2 * linter * fixbuild * UI design overhaul (#937) * Phase 1: UI design overhaul * added phase 2 changes * review feedback * added changeset * added inline comment explain for provider hint * Release packages (#940) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Auth: Prevent /start calls when logged in (#941) * Auth: Prevent /start calls when logged in * added changeset * added changeset * fixed tests * Release packages (#942) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Jonathan/feat add default email (#944) * Feat: added default email prop * added changeset * Auth: add onLoginSuccess callback (#943) * Auth: add onLoginSuccess callback * added changeset * made onloginsuccess callback only fire onlogin * Release packages (#945) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * auth: allow local jwks (#946) * auth: allow local jwks * change * Release packages (#947) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: onSuccessLogin callback (#948) * Fix: onSuccessLogin callback * added changeset * fixed test * removed experimental * Release packages (#949) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: onSuccessLogin callback add prop (#950) * Fix: onSuccessLogin callback add prop * fixed test * added changeset * Release packages (#951) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Jonathan/fix resend button (#952) * Fix: onSuccessLogin callback add prop * fixed test * added changeset * Fix: otp resend button and duration * added changeset * removed old changeset * Release packages (#953) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Jonathan/fix continue with google btn (#954) * Fix: when we show continue w/ google btn * added changeset * Release packages (#955) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * checkout: update types for product locator (#957) * update types * change * Release packages (#958) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * EmbeddedAuthForm: fix Google icon size on initial page load (#959) * Fix: Google icon size on initial page load * added changeset * Release packages (#960) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update: nanoid (#961) * update nanoid * add changeset * Release packages (#962) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: remove "creationSeed" during wallet creation * feat: add Story blockchain * fix: format * fix: use defined literals for viem network mapping * fix: wallet creation in react sdk * fix: createPasskeySigner params * fix: update import paths * test: add stub test case * fix: passkey wallet creation in react sdk * fix: create passkey wallet by default in react sdk --------- Co-authored-by: mPaella <[email protected]> Co-authored-by: Alberto Elias <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan <[email protected]> Co-authored-by: Pablo Egido <[email protected]> Co-authored-by: Alberto <[email protected]> Co-authored-by: Julio Jordán <[email protected]>
Destiner
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Auth: add onLoginSuccess callback * added changeset * made onloginsuccess callback only fire onlogin
Destiner
added a commit
that referenced
this pull request
Feb 25, 2025
* fix(smart-wallet): lint * refactor(smart-wallet): clean up * feat(smart-wallet)!: init rewrite * remove all code * use API * wallet creation & tx sending for ECDSA signers * clean up dependencies * auth: twitter user type (#910) * auth user type: twitter * changeset * chore(smart-wallet): install ox * feat(smart-wallet): passkey signer * wallet creation * transaction sending flow * feat(smart-wallet): signatures * `signMessage` * `signTypedData` * feat(smart-wallet): implement `getNonce` * feat(smart-wallet): add transferToken, nfts, executeContract * refactor(smart-wallet): format * fix(smart-wallet): export EVMSmartWallet * fix(smart-wallet): specify chain when querying NFTs * fix(smart-wallet): remove unused file * chore(smart-wallet): bump version * Auth: Adapts server sdk to non-nodejs envs and adds example to next auth app (#912) * Adapts server sdk to non-nodejs envs and adds example to next auth app with middleware * pnpm lock * Release packages (#911) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(smart-wallet): use /me endpoints * fix(smart-wallet): throttle status requests * fix(smart-wallet): exports * feat(smart-wallet): passkey credential creation * docs(smart-wallet): add README * docs(smart-wallet): README fixes * docs(smart-wallet): README edits * fix(smart-wallet): remove custom errors from docs * fix(smart-wallet): improve API response schema * feat(smart-wallet): custom errors * chore(smart-wallet): changesets * docs(smart-wallet): migration guide * feat(smart-wallet): implement writeContract * fix(smart-wallet): null checks * Auth: Improve janky animations and UX (#917) * Auth: Improve janky animations and UX * added changeset * Release packages (#918) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * pay-with-crypto: better handle scenarios when chain not supported (#916) * pay-with-crypto: better handle scenarios when chain not supported * changeset * requested change * lint * asd * asd * Release packages (#919) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add Story testnet (#914) * docs(smart-wallet): update README * fix(smart-wallet): revert package version this will be updated automatically * fix(smart-wallet): group changesets * fix(smart-wallet): use CrossmintApiClient * fix(smart-wallet): move types to a separate file * fix(smart-wallet): move types into a separate file * fix(react-ui): use latest smart wallet SDK * fix: format * fix: update changeset * order: update type (#923) * save * changeset * Release packages (#924) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * embedded-props: add execution parameters (#920) * embedded-props: add execution parameters * changeset * adding token locator * lint * lint * reset * lint * adjustment * Release packages (#925) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chain: add Chiliz (#926) * chain: add Chiliz * lint * changeset * Release packages (#927) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Wallet Demo: Updated verbiage (#928) * SmartWalletsSDK: add Story testnet (#930) * SmartWalletsSDK: add Story testnet * double quotes * linthappy * minor * Auth: Optionally dont throw when cookies not found (#929) * Dont throw unhandled errors if cookies not found in req when expected in the body * changes * fixes pr comments * fix build * auth: initializing status (#932) * save * change * Release packages (#931) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * embedded: fixing embedded checkout types for line items (#933) * embedded: fixing embedded checkout types for line items * asd * Release packages (#934) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: stale JWT re-render bug (#935) * Fix: stale JWT re-render bug * added changeset * Release packages (#936) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Story: add mainnet (#938) * Story: add mainnet * fixlint * fixlint2 * linter * fixbuild * UI design overhaul (#937) * Phase 1: UI design overhaul * added phase 2 changes * review feedback * added changeset * added inline comment explain for provider hint * Release packages (#940) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Auth: Prevent /start calls when logged in (#941) * Auth: Prevent /start calls when logged in * added changeset * added changeset * fixed tests * Release packages (#942) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Jonathan/feat add default email (#944) * Feat: added default email prop * added changeset * Auth: add onLoginSuccess callback (#943) * Auth: add onLoginSuccess callback * added changeset * made onloginsuccess callback only fire onlogin * Release packages (#945) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * auth: allow local jwks (#946) * auth: allow local jwks * change * Release packages (#947) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: onSuccessLogin callback (#948) * Fix: onSuccessLogin callback * added changeset * fixed test * removed experimental * Release packages (#949) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix: onSuccessLogin callback add prop (#950) * Fix: onSuccessLogin callback add prop * fixed test * added changeset * Release packages (#951) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Jonathan/fix resend button (#952) * Fix: onSuccessLogin callback add prop * fixed test * added changeset * Fix: otp resend button and duration * added changeset * removed old changeset * Release packages (#953) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Jonathan/fix continue with google btn (#954) * Fix: when we show continue w/ google btn * added changeset * Release packages (#955) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * checkout: update types for product locator (#957) * update types * change * Release packages (#958) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * EmbeddedAuthForm: fix Google icon size on initial page load (#959) * Fix: Google icon size on initial page load * added changeset * Release packages (#960) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update: nanoid (#961) * update nanoid * add changeset * Release packages (#962) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: remove "creationSeed" during wallet creation * Merge branch 'main' of github.com:Destiner/crossmint-sdk * feat: add Story blockchain * fix: format * fix: use defined literals for viem network mapping * fix: wallet creation in react sdk * fix: createPasskeySigner params * fix: update import paths * test: add stub test case * fix: passkey wallet creation in react sdk * fix: create passkey wallet by default in react sdk * fix: build * fix: format --------- Co-authored-by: mPaella <[email protected]> Co-authored-by: Alberto Elias <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jonathan <[email protected]> Co-authored-by: Pablo Egido <[email protected]> Co-authored-by: Alberto <[email protected]> Co-authored-by: Julio Jordán <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a callback for successful logins called onLoginSuccess
Test plan
works for both pre-wallet users and logged in users
Package updates
@crossmint/client-sdk-react-ui