Skip to content

fix: fix activityTypes Tinybird data source sorting key #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix: fix activityTypes Tinybird data source sorting key #3509

merged 1 commit into from
Oct 15, 2025
+4 −1

Conversation

borfast
Copy link
Collaborator

@borfast borfast commented Oct 14, 2025 •
edited
Loading

In the activityTypes Tinybird data source, we were missing the activityType field in the ENGINE_SORTING_KEY, which caused problems with deduplication.

This fixes it, and also removes isCodeContribution and isCollaboration from the sorting key to also prevent issues with duplicates, in case we change a setting in one of the activity types.

Note: there's no Jira ticket for this one, as this was an emergency fix yesterday.

@borfast borfast requested a review from epipav October 14, 2025 10:08
@borfast borfast self-assigned this Oct 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@borfast borfast force-pushed the fix/fix-activity-types-sorting-key branch from 6a59a90 to ac0ac69 Compare October 14, 2025 15:18
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@borfast borfast force-pushed the fix/fix-activity-types-sorting-key branch from ac0ac69 to 1afca5a Compare October 14, 2025 15:24
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@borfast borfast requested a review from gaspergrom October 14, 2025 15:44
@borfast borfast force-pushed the fix/fix-activity-types-sorting-key branch from 1afca5a to 894178a Compare October 14, 2025 16:09
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

cursor[bot]

This comment was marked as outdated.

Sign in to view

@borfast borfast force-pushed the fix/fix-activity-types-sorting-key branch from 894178a to e5e8419 Compare October 14, 2025 16:12
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

gaspergrom
gaspergrom approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@gaspergrom gaspergrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix copilot comment

@borfast borfast force-pushed the fix/fix-activity-types-sorting-key branch from e5e8419 to 5afb9f4 Compare October 15, 2025 08:48
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@borfast borfast merged commit c5fd04a into main Oct 15, 2025
15 checks passed
@borfast borfast deleted the fix/fix-activity-types-sorting-key branch October 15, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@gaspergrom gaspergrom gaspergrom approved these changes

@epipav epipav Awaiting requested review from epipav

Assignees

@borfast borfast

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@borfast @gaspergrom