Preserve repo volume status when error occurs during apply #4281
+32
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update ensures that the repo volume status is preserved in cases where there is an error when applying the repo volume. When there is an error, the status is now preserved until the underlying issue is corrected. Issue: PGO-2654
Certain variables make the behavior of the volume auto-grow code unclear. This updates variables and adds a comment to better indicate the behavior in question.
tjmoore4
force-pushed
the
preserve-repo-vol-status
branch
from
e2ddec3 to
4265e94
Compare
tjmoore4
changed the title
jmckulk
reviewed
Sep 11, 2025
| if dpv, err := getDesiredVolumeSize( | ||
| // Determine the appropriate volume request based on what's set in the status. | ||
| // Note: request size set by reference. | ||
| if badDesiredVolumeRequest, err := getDesiredVolumeSize( |
There was a problem hiding this comment.
why is the output here always "bad" ❓
There was a problem hiding this comment.
Because that value is only ever returned if resource.ParseQuantity was unable to parse it. It's only use is for the error logging below.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
If an error occurs when applying a repo host volume, any existing status will be lost.
What is the new behavior (if this is a feature change)?
Update to ensure that the repo volume status is preserved in
cases where there is an error when applying the repo volume. When
there is an error, the status is now preserved until the underlying
issue is corrected.
Also, updates certain variables make the behavior of the volume auto-grow code
unclear. This updates variables and adds a comment to better
indicate the behavior in question.
Other Information:
Issue: PGO-2654