Column Refactor + Jumpmenu update #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Big refactors to how columns are built to be more dynamic rather than prewritten divs per column. This decision was made to cleanup the code and to add in information for column eminence. Main and auxiliary columns need to be labeled as such for jump navs to render properly. The column eminence mainly affects the two and three column layouts as they can have varying sizes based on user choice. Equal width columns (6-6 and 4-4-4) are treated all as "main"
patrickbrown-io
approved these changes
Jan 13, 2025
Contributor
patrickbrown-io
left a comment
patrickbrown-io
left a comment
There was a problem hiding this comment.
Works well in selecting the headers and the main content for the jump menu!
Tested 1-4 column sections on the same page with various widths for each section and the jump menu correctly grabs the largest column per section, or all if they are uniform.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
Column Refactor + Jumpmenu update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big refactors to how columns are built to be more dynamic rather than prewritten divs per column. This decision was made to cleanup the code and to add in information for column eminence. Main and auxiliary columns need to be labeled as such for jump navs to render properly.
The column eminence mainly affects the two and three column layouts as they can have varying sizes based on user choice. Equal width columns (6-6 and 4-4-4) are treated all as "main"
When testing please test all the layout options for columns in the layout builder.
I don't think I missed any of the layout options in my refactor but double checks would be helpful.
Sister PR: CuBoulder/ucb_ckeditor_plugins#100
Resolves #63