Various: add public IP selector setting #822
Draft
+135
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceOfWraith
previously approved these changes
Jun 6, 2024
|
Remind me what the issue was with merging this one? I know we talked about it somewhere already. |
|
The manifest doesn't know about the kvp vars so can't write them into configs |
|
I'm interessed in the PublicIP variable that is add to Astroneer config. |
|
Can we PLEASE check this again to see if it can be approved? Astronomer has been historically unable to pull a public IP on my servers. |
|
It can't yet. |
|
I've encountered this issue as well and await its to be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.