Skip to content

Add sponge platform#78

Open
Nuckerr wants to merge 6 commits into
Cubxity:dev/0.3.xfrom
Nuckerr:dev/0.3.x
Open

Add sponge platform#78
Nuckerr wants to merge 6 commits into
Cubxity:dev/0.3.xfrom
Nuckerr:dev/0.3.x

Conversation

@Nuckerr

@Nuckerr Nuckerr commented Oct 8, 2022

Copy link
Copy Markdown

Adds support for sponge platform. I've only tested through influx dashboard. Needs testing in grafana. Aims to solve #21

@Cubxity Cubxity left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Here is my rough review.

Important: please format the code properly.

Comment thread api/src/main/kotlin/dev/cubxity/plugins/metrics/api/platform/PlatformType.kt Outdated
Comment thread api/src/main/kotlin/dev/cubxity/plugins/metrics/api/platform/PlatformType.kt Outdated
Comment thread platforms/sponge/build.gradle.kts Outdated

@Cubxity Cubxity left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is still not formatted properly.

@Nuckerr
Nuckerr requested a review from Cubxity October 12, 2022 14:11
@Nuckerr

Nuckerr commented Oct 16, 2022

Copy link
Copy Markdown
Author

@Cubxity anything else you want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants