-
-
Notifications
You must be signed in to change notification settings - Fork 38
add cdx:python:package:marker property
#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cdx:python:package:marker property
#142
Conversation
|
according to python packaging,
CycloneDX does not allow properties in the dependency graph. Anyway, the proposed property Please discuss/explain why you think this makes sense. |
Suppose we have a Python project with the following Then we know that "properties": [
{
"name": "cdx:python:package:marker",
"value": "python_full_version >= '3.12' or sys_platform == 'win32'"
}
]While the docs do indeed mention dependencies, we are still treating Specifically on this point
I don't follow your reasoning - if the user is on darwin and Python 3.11, then the package won't be used, so it is surely having an effect. |
Agree with @jkowalleck. I think this falls into the broader bucket of what you are producing an SBOM for - it should be for the shippable thing, which is perhaps a more complex thing in Python:
In summary - don't think we should just add this property without wider consideration - it could lead to confusion and miss-use of CycloneDX as a BOM format IHMO. |
See PR here for reasoning: CycloneDX/cyclonedx-property-taxonomy#142
|
Thank you both for the comments - will close the PR given the discussion above |
See PR here for reasoning: CycloneDX/cyclonedx-property-taxonomy#142
See PR here for reasoning: CycloneDX/cyclonedx-property-taxonomy#142
See PR here for reasoning: CycloneDX/cyclonedx-property-taxonomy#142
This PR adds a property
markerto thecdx:python:packagenamespace, which represents the resolved marker expression for all occurrences of a dependency, as described in the specification here.