Skip to content

feat!: ignore unknown properties when deserializing #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 21, 2025

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jul 17, 2025

when deserializing JSON: ignore unknown/unsupported properties
when deserializing XML: ignore unknown/unsupported attributes and elements

this is considered a BREAKING Change, as the old behavior was to throw an error when deserializing unknown/unsupported features - which no longer happens, instead, unknown/unsupported features are simply ignored.



@jkowalleck jkowalleck requested a review from a team as a code owner July 17, 2025 10:23
@jkowalleck jkowalleck added the QA Quality Assurance label Jul 17, 2025
@jkowalleck
Copy link
Member Author

test currently failing due to madpah/serializable#176

@jkowalleck jkowalleck self-assigned this Jul 17, 2025
@jkowalleck jkowalleck added enhancement New feature or request breaking change labels Jul 18, 2025
@jkowalleck jkowalleck changed the title tests: regression for issue #850 feat!: silently ignore unknown properties when deserializing Jul 18, 2025
@jkowalleck jkowalleck changed the title feat!: silently ignore unknown properties when deserializing feat!: silently unknown properties when deserializing Jul 18, 2025
@jkowalleck jkowalleck changed the title feat!: silently unknown properties when deserializing feat!: ignore unknown properties when deserializing Jul 18, 2025
@jkowalleck jkowalleck marked this pull request as draft July 18, 2025 09:21
@jkowalleck jkowalleck force-pushed the tests/regression_issue850 branch from c17fa88 to 415e002 Compare July 21, 2025 10:00
Signed-off-by: Jan Kowalleck <[email protected]>
Copy link

codacy-production bot commented Jul 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2cfb3d6) 5642 5281 93.60%
Head commit (27e4945) 5642 (+0) 5281 (+0) 93.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#853) 59 59 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck jkowalleck marked this pull request as ready for review July 21, 2025 10:08
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck merged commit 4842828 into main Jul 21, 2025
48 checks passed
@jkowalleck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request QA Quality Assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: load XML with ##other elements and ##any attributes
1 participant