Open
Conversation
userId๋ฅผ ์ด์ฉํ์ฌ ์ฑํ ์ฐฝ์ ๋ถ๋ฌ์ฌ ์ ์์ต๋๋ค.
๋ฉ์ธ์ง๋ฅผ ๋ณด๋ธ ์ฌ๋์ nickname ์ผ๋ก ๋ณด์ฌ์ค
์ฑํ ์์ ์๋๋ฐฉ ํ๋กํ์ ๋๋ ์๋ BottomSheet User Info ๋ํ๋๋๋กํ์์
Kick-snare
reviewed
Nov 29, 2022
| upPress: () -> Unit = {}, | ||
| viewModel: ChattingDetailViewModel = hiltViewModel() | ||
| viewModel: ChattingDetailViewModel = hiltViewModel(), | ||
| userFeedViewModel: UserFeedViewModel = hiltViewModel(), |
Member
There was a problem hiding this comment.
viewModel์ด ์ฌ๋ฌ๊ฐ ์ฃผ์ ๋๋ค๋ฉด ์ด๋ฆ์ chattingDetailViewModel๊ณผ ๊ฐ์ด ๊ตฌ๋ถํ๋๊ฒ ๋ ์ข์๊ฒ ๊ฐ์์!
Kick-snare
approved these changes
Nov 29, 2022
Member
There was a problem hiding this comment.
๊ณ ์ํ์ จ์ต๋๋ค. ์ ๊ฐ ํ์ธํ ๊ฐ์ ์ฌํญ์ ์๋์ ๊ฐ์ต๋๋ค.
- ํค๋ณด๋์ ์ ๋ ฅ์นธ์ด ์ฝ๊ฐ ์๋ฆฌ๋ ํ์์ ํ์ธํ์ต๋๋ค.
- chatting title? ์ด ๋ํ๋์ง ์์ต๋๋ค.
- ์ด๋ฏธ์ง๊ฐ ๋ฆฌ๋ทฐ ๋ชจ์ง๊ธ์ ๊ฒ๊ณผ ์ฐ๋๋์ผ ํฉ๋๋ค.
- ์๋๋ก๊ทธ์ธ ์ userId๋ฅผ ๋น๋กฏํ ์ ๋ณด๋ค์ด ์ฑ์์ง์ง์์ defalut์ธ userId 0์ ๋ณด์ฌ์ค๋๋ค. #138
Kick-snare
reviewed
Nov 29, 2022
| private val firebaseDatabase = FirebaseDatabase.getInstance() | ||
| private val databaseReference = firebaseDatabase.reference | ||
|
|
||
| var chatList : MutableList<Pair<Long,Chat>> = mutableStateListOf() |
Member
There was a problem hiding this comment.
Pair<Long, Chat> ๊ณผ ๊ฐ์ด ์ ์ฅํ๋ readabillty๊ฐ ๋จ์ด์ง๋ ๊ฒ ๊ฐ์ต๋๋ค. model์ ๋ง๋๋๊ฑด ์ด๋จ๊น์?
Kick-snare
reviewed
Nov 29, 2022
| @@ -81,7 +81,12 @@ fun NavGraphBuilder.divideGraph( | |||
| ) { backStackEntry -> | |||
| val arguments = requireNotNull(backStackEntry.arguments) | |||
| val chattingId = arguments.getInt(DetailDestinationKey.CHATTING) | |||
Member
There was a problem hiding this comment.
composable(
"${Screen.RecruitingDetailScreen.route}/{${DetailDestinationKey.RECRUITING}}",
arguments = listOf(navArgument(DetailDestinationKey.RECRUITING) { type = NavType.LongType })
) { backStackEntry ->
val arguments = requireNotNull(backStackEntry.arguments)
val recruitingId = arguments.getInt(DetailDestinationKey.RECRUITING)
RecruitingDetailScreen(
postId = recruitingId,
upPress = upPress,
navController = navController,
onChattingSelected = {id -> onChattingClick(id, backStackEntry)}
)
}Key recruitingId expected Integer but value was a java.lang.Long.
The default value 0 was returned.
java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.Integer
type ๋ฌธ์ ๊ฐ ์กด์ฌํ๋๊ฒ ๊ฐ์ต๋๋ค!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



์ฃผ์๋ด์ฉ