Redfs ubuntu fix ff->iomode warning#103
Merged
bsbernd merged 1 commit intoMar 3, 2026
Merged
Conversation
This is a backport of upstream commit: 4864a6d But due to the fact that Linux 6.8 does not have the passthrough feature that commit cannot be cherry picked without a de facto rewrite. (E.g. the struct fuse_backed is not even defined) Signed-off-by: Horst Birthelmer <[email protected]>
bsbernd
reviewed
Mar 2, 2026
| fuse_inode_uncached_io_end(fi); | ||
| inode_unlock_shared(inode); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I might miss it, but what about fuse_file_mmap?
@@ -2574,8 +2574,10 @@ static int fuse_file_mmap(struct file *file, struct vm_area_struct *vma)
* First mmap of direct_io file enters caching inode io mode.
* Also waits for parallel dio writers to go into serial mode
* (exclusive instead of shared lock).
+ * After first mmap, the inode stays in caching io mode until
+ * the direct_io file release.
*/
- rc = fuse_file_cached_io_start(inode, ff);
+ rc = fuse_file_cached_io_open(inode, ff);
if (rc)
return rc;
}
``
Collaborator
Author
There was a problem hiding this comment.
-int fuse_file_cached_io_start(struct inode *inode, struct fuse_file *ff)
+int fuse_file_cached_io_open(struct inode *inode, struct fuse_file *ff)
This was just a rename, which I didn't do. There was no functional change in the function except a comment
bsbernd
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of upstream commit:
4864a6d
But due to the fact that Linux 6.8 does not have the passthrough feature that commit cannot be cherry picked without a de facto rewrite. (E.g. the struct fuse_backed is not even defined)