Revert "fuse: invalidate the page cache after direct write"#105
Merged
bsbernd merged 1 commit intoMar 2, 2026
Merged
Conversation
This reverts commit f6de786.
Collaborator
|
@cding-ddn I don't think the commit message is right. Let's say one runs single thread fuse, why shouldn't it be an issue then? |
bsbernd
approved these changes
Mar 2, 2026
bsbernd
approved these changes
Mar 2, 2026
Collaborator
Author
You are right. single thread fuse will fail too. I emphasize coroutine mainly to distinguish it from multi-threading. coroutine/reactor-based fuse could fail as that's what we have tested (though they don't have to fail if they call reply_data in a separated thread) . I would assume multi-thread based fuse works - otherwise the author of f6de786 will not pass his test case. I realized that I need to revert it from other branches too, going to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f6de786.
f6de786 causes deadlock on coroutine based fuse daemon when running AIO + buffered I/O mixed workload.